Fix hcap detail #212
Merged
Fix hcap detail #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foysalit
requested changes
Oct 3, 2024
| @@ -534,7 +534,7 @@ function Details({ | |||
| )} | |||
| {hcapDetail && ( | |||
| <DataField value={ip} label="Hcaptcha"> | |||
| {Object.entries(hcapDetail).map(([property, value]) => ( | |||
| {hcapDetail.map(({ property, value }) => ( | |||
There was a problem hiding this comment.
.map will fail if hcapDetail undefined so you can either fallback to [] up top or just ?. here.
| const hcapDetail = Array.isArray(repo.hcaptchaDetails) | ||
| ? (repo.hcaptchaDetails as { property: string; value: string }[]) | ||
| : undefined | ||
| console.log(hcapDetail) |
There was a problem hiding this comment.
nix the console.log and we're good!
arcalinea
temporarily deployed
to
fix-hcap-detail - ozone-staging PR #212
Render
Destroyed
foysalit
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hcap details were changed from a record format (
{[property]: value}) to an array format ({property, value}[]).