Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Show resolve appeal action on workspace #215

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

foysalit
Copy link
Contributor

@foysalit foysalit commented Oct 4, 2024

This PR adds the resolve appeal action in workspace and fixes infinite loader display issue on search page.

@arcalinea arcalinea temporarily deployed to resolve-appeal-on-workspace - ozone-staging PR #215 October 4, 2024 09:09 — with Render Destroyed
@@ -31,6 +31,7 @@ export const WorkspacePanelActionForm = ({
selectedAction={modEventType}
isSubjectDid={false}
hasBlobs={false}
forceDisplayActions={[MOD_EVENTS.RESOLVE_APPEAL]}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right now, we just want an escape hatch to be able to tell the selector to bypass any check. in the future, we will do the check ourselves before enforcing here. this is just not possible today with the data we have in the workspace to determine if resolve appeal should show up or not so for now, we just force display it without a check.

@foysalit foysalit merged commit 9bdb3d8 into main Oct 4, 2024
3 checks passed
@matthieusieben matthieusieben deleted the resolve-appeal-on-workspace branch November 15, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants