✨ Use settings api to store queue config #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
reviewed
Oct 30, 2024
app/reports/page-content.tsx
Outdated
Comment on lines
439
to
440
| function getQueueIndex(did: string, queueNames: string[], queueSeed: string) { | ||
| return simpleHash(did + queueSeed) % queueNames.length |
There was a problem hiding this comment.
If we're making changes here, I might recommend flipping this around a little since I think it will work better with reshuffling based on the seed (given how the simple hash function works).
Suggested change
| function getQueueIndex(did: string, queueNames: string[], queueSeed: string) { | |
| return simpleHash(did + queueSeed) % queueNames.length | |
| function getQueueIndex(did: string, queueNames: string[], queueSeed: string) { | |
| return simpleHash(`${queueSeed}:${did}`) % queueNames.length |
devinivy
approved these changes
Oct 30, 2024
arcalinea
temporarily deployed
to
ozone-settings - ozone-staging PR #222
Render
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on bluesky-social/atproto#2905
This PR moves queue config (queue list and seed) from env var to ozone settings API.