Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty search results, fix via eager pagination #2359

Open
estrattonbailey opened this issue Dec 28, 2023 · 5 comments
Open

Empty search results, fix via eager pagination #2359

estrattonbailey opened this issue Dec 28, 2023 · 5 comments
Assignees
Labels
blocked Waiting on a separate issue to finish

Comments

@estrattonbailey
Copy link
Member

Searching for some terms in the app shows no results due to labels being filtered out and an empty page being returned. We should eagerly fetch multiple pages to fill a queue, up to a point. Maybe fetch the first 6 pages or 30 posts, whichever limit we reach first (mimics post feeds).

@estrattonbailey
Copy link
Member Author

Update: tested this out in a PR (linked above) and e.g. searching for bluesky and paginating 10 pages and 300 posts returned no results.

@estrattonbailey estrattonbailey added the blocked Waiting on a separate issue to finish label Dec 28, 2023
@Zero3K
Copy link

Zero3K commented Jan 10, 2024

This is still occurring.

@DavidBuchanan314
Copy link
Contributor

What's the root cause of so many filtered posts being returned at once? Intuitively I'd expect it to be a rare edge-case, but its happening consistently for certain keywords. Is it perhaps related to createdAt timestamp spoofing? (causing certain posts to get "stuck" at the top)

@estrattonbailey
Copy link
Member Author

I believe the main cause we're aware of are posts labeled as spam, and our search endpoint aggressively filtering those out. We plan to dedicate more time to it soon, obviously not a good experience atm.

@mschwendener
Copy link

Both bluesky and london now show search results, seems to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Waiting on a separate issue to finish
Projects
None yet
Development

No branches or pull requests

4 participants