Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invisible url when only a protocol #1059

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Conversation

styfle
Copy link
Contributor

@styfle styfle commented Jul 25, 2023

@DavidBuchanan314
Copy link
Contributor

I'm not sure about this strategy. If I made the following post, expressed in markdown syntax:

I'm going to see [Spider-Man: Into the Spiderverse](https://www.imdb.com/title/tt4633694/) in the cinema

(use your imagination for the corresponding facets)

Then this post would get rendered as:

I'm going to see Into the Spiderverse in the cinema

When it really ought to be:

I'm going to see Spider-Man: Into the Spiderverse in the cinema

@styfle
Copy link
Contributor Author

styfle commented Jul 25, 2023

@DavidBuchanan314 Good point! I updated in 91fae09 to include your suggestion.

Copy link
Collaborator

@pfrazee pfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks folks!

@pfrazee pfrazee merged commit 5a0899b into bluesky-social:main Jul 27, 2023
@styfle styfle deleted the patch-1 branch July 27, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bare URLs ending in a colon become invisible when rendered as a facet
3 participants