Add enter/exit animations to modals on web #2042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh fire, I'll try to get this reviewed sooner than later. May be next week. Thanks mozzy! |
pfrazee
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Layout transitions on web just dropped for Reanimated 3.6.0, so I added them to the modals. Makes the web app feel a lot more fluid.
The default reanimated animations are not the most beautiful animations, so I kept them as quick fades for the most part. I attempted to make nicer keyframe ones but that doesn't appear to work properly on web yet.
NOTE: I had to update the reanimated version, so that may impact some of the more complex animation stuff you've got going on
Video:
Screen.Recording.2023-11-30.at.12.35.30.mov