Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3rd party embedded player (can't finish right now, tossing up here) #2107

Closed
wants to merge 1 commit into from

Conversation

pfrazee
Copy link
Collaborator

@pfrazee pfrazee commented Dec 6, 2023

This was a weekend project we don't have time to finish, but if anybody in the community is inclined, feel free to take this to the finish line.

Here are my TODO notes from when I was working on it

  • twitch parent param
  • needed origin?
  • parse tests
  • dark mode
  • no image render
  • fix android in viewport
  • fix android dimensions
  • remove hack

@mackuba
Copy link

mackuba commented Dec 7, 2023

That would definitely be cool to have! 👍

@chilblane
Copy link

possibility of getting soundcloud and bandcamp support in this pr as well? (whoever does it)

@haileyok haileyok mentioned this pull request Dec 15, 2023
@pfrazee pfrazee closed this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants