Add PWI opt-out toggle #2122
Merged
Add PWI opt-out toggle #2122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
reviewed
Dec 7, 2023
| } | ||
| updateProfile.mutate({ | ||
| profile, | ||
| updates: existing => { |
There was a problem hiding this comment.
I realize this is not new, but are we mutating something that's also used for rendering? Generally in React we shouldn't mutate stuff we render — can this be a new object?
There was a problem hiding this comment.
It's not being used for rendering. I agree with the general approach as a safe default approach, but this is a narrow non-react api that handles this okay. Not against changing it, but not an issue
There was a problem hiding this comment.
ah if we don't render it then cool
gaearon
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just adds the opt-out toggle. The behaviors for handling the opt-out can come in a follow-up PR (not a blocker until we enable the PWI).
Current copy
Previous iterations (no longer current)