Mark more text for localization #2210
Conversation
|
I think it should be fine to merge, what do you think? |
|
+1 from another Korean user. I've reviewed translations and confirming I do not find any typo or error. |
src/locale/locales/uk/messages.po
Outdated
There was a problem hiding this comment.
Can you delete all the .po files just so we don't have a lot of merge conflcits??
| @@ -91,7 +91,7 @@ export function Component({onSelect}: {onSelect: (url: string) => void}) { | |||
| <TextInput | |||
| testID="customServerTextInput" | |||
| style={[pal.borderDark, pal.text, styles.textInput]} | |||
| placeholder="e.g. https://bsky.app" | |||
| placeholder={_(msg`e.g. https://bsky.app`)} | |||
There was a problem hiding this comment.
We don't want to localize a URL
There was a problem hiding this comment.
I included it in the localization because of e.g.. Is it okay to wrap the URL in ${}?
|
|
||
| type ReasonMap = Record<string, {title: string; description: string}> | ||
| const CommonReasons = { | ||
| [ComAtprotoModerationDefs.REASONRUDE]: { | ||
| title: 'Anti-Social Behavior', |
There was a problem hiding this comment.
@pfrazee Do we want to localize these strings?
| const triggerPush = () => { | ||
| // TODO: implement local notification for testing | ||
| } | ||
| const triggerToast = () => { | ||
| Toast.show('The task has been completed') | ||
| Toast.show(_(msg`The task has been completed`)) |
There was a problem hiding this comment.
We can remove these are no point in localizing the Debug.tsx file
There was a problem hiding this comment.
It looks like there are other localized strings already in the Debug.tsx file, does that make any difference?
There was a problem hiding this comment.
Most of the changes from this PR were merged with #2440
So I'll leave it to @pfrazee if this needs to be merged.
But the best solution would be to create a new clean PR with the few leftover strings. Or at the very least delete the generated .po files from this PR so it can be reviewed in depth again.
I also left some comments about some text that we might not want to localize.
In any case, really appreciate your contributions @quiple . Most of them were merged in a different PR but thank you very much nonetheless!!
|
@ansh Thanks for review! I'll request a new PR later. |
No description provided.