Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and fix Japanese localization #2374

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

noritada
Copy link
Contributor

This PR adds translations for some messages, and also fixes some existing translations.

Dear @Hima-Zinn @tkusano @dolciss @oboenikui
I would appreciate your review and feedback on these text updates.

Many thanks!

@ansh
Copy link
Contributor

ansh commented Dec 29, 2023

Thank you! And thank you for tagging the other contributors. Looking forward to getting some consensus from the other native Japanese speakers.

Copy link
Contributor

@dolciss dolciss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正ありがとうございます!
1点提案と、2点表記揺れをコメントしましたので確認お願いします。

@@ -434,7 +434,7 @@ msgstr "入力したメールアドレスの受信トレイを確認して、以

#: src/view/com/modals/Threadgate.tsx:72
msgid "Choose \"Everybody\" or \"Nobody\""
msgstr ""
msgstr "「全員」と「返信不可」のどちらかを選択するか"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

後ろで「または~」としているので、

Suggested change
msgstr "「全員」と「返信不可」のどちらかを選択するか"
msgstr "「全員」と「返信不可」のどちらかを選択"

で良いように思います

@@ -1204,7 +1204,7 @@ msgstr "ローカル開発者サーバー"

#: src/view/screens/Moderation.tsx:136
msgid "Logged-out visibility"
msgstr "ログアウトした状態の可視性"
msgstr "ログアウトしたユーザからの可視性"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

表記揺れ

Suggested change
msgstr "ログアウトしたユーザからの可視性"
msgstr "ログアウトしたユーザーからの可視性"

@@ -1837,7 +1837,7 @@ msgstr "検索"
#: src/view/com/auth/LoggedOut.tsx:104
#: src/view/com/auth/LoggedOut.tsx:105
msgid "Search for users"
msgstr ""
msgstr "ユーザを検索"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

表記揺れ

Suggested change
msgstr "ユーザを検索"
msgstr "ユーザーを検索"

@noritada noritada force-pushed the l10n/ja-po-updates-20231230 branch from 0563c94 to 1f47d08 Compare December 30, 2023 02:37
@noritada
Copy link
Contributor Author

@dolciss Thank you for your review!
I have applied your suggestions to remove notation inconsistencies, etc.

@dolciss
Copy link
Contributor

dolciss commented Dec 30, 2023

@noritada Thanks for applying!
LGTM

@ansh ansh merged commit 032a5bd into bluesky-social:main Jan 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants