-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve French localization #2393
Conversation
Really appreciate your feedback @Signez ! Till we figure out a formal process for reviewing translations, right now we are just waiting until there is a 2+ native speaker consensus on changes before merging. So, I'll wait till anyone else has anything to chime in here. |
src/locale/locales/fr/messages.po
Outdated
@@ -1334,7 +1338,11 @@ msgstr "Nouvelle publication" | |||
|
|||
#: src/view/shell/desktop/LeftNav.tsx:258 | |||
msgid "New Post" | |||
msgstr "Nouvelle publication" | |||
msgstr "Nouv. publication" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think this could be translated as "Nouvelle Poste?"
For example, other sites use the french word "Poster" for "Post"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, this could be translated to Nouveau post
! (Yeah, post
is masculine in French, whereas publication
is feminine, so it would be Nouveau
and not Nouvelle
in that case.)
I didn't want to change publication
to post
in my pull request because I didn't want, as a first contribution, change all mentions of publications
into post
— but I think it would be a good call, as users are used to post
to refer to it, both in writing and in speaking.
If you don't mind this change, I can make the move from publication
to post
in that pull request. Waiting for your green light to do so :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that would be great!
Again, want to thank you a lot for your help here. Please add yourself to the "Last-Translator: \n" "Language-Team: \n"
header in the messages.po
file if you haven't done so already!
I've just done it! Note that even though I'm not a professional translator, I used to work on a product that spanned several languages ( on a pan-European website selling train tickets), and I helped localize that product, so I'm quite familiar with this kind of endeavor, and the challenges you face. 🤗 |
- Add missing translations - Always use French guillemets («») when applicable - Always add an article (le/la/l’) before nouns - Use … character instead of three dots - Change "Mettre en sourdine" into "Masquer", used in other products for "Mute" (and shorter) - Change other usages of "Masquer" into its synonym "Cacher" to prevent confusion between concepts - Shorten "Nouvelle publication" into "Nouv. publication" to prevent it overflowing in the main blue button - Fixed other little errors
26a3631
to
a18244b
Compare
This pull request is now rebased, updated with the two new strings extracted from the codebase, and with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging so it does not go stale
This pull request tries to improve the French localization effort that was already done earlier this month in #2265 (quite well, actually! Congratulations, coming from a native speaker who is nitpicky about translations in software products! 💛).
yarn intl:extract
and translated the empty ones)Shorten "Nouvelle publication" into "Nouv. publication" to prevent it overflowing in the main blue buttonIt's my first contribution to Bluesky, feel free to tell me if I did something that could have been better for my future contributions :) (I may submit improvements to i18n too, there are some strings that are hard to fix as-is for now because of some string concatenations, so I may suggest some improvements on that later if you are open for those.)