Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve French localization #2393

Merged
merged 5 commits into from
Jan 3, 2024

Conversation

Signez
Copy link
Contributor

@Signez Signez commented Dec 31, 2023

This pull request tries to improve the French localization effort that was already done earlier this month in #2265 (quite well, actually! Congratulations, coming from a native speaker who is nitpicky about translations in software products! 💛).

  • Add missing translations (I just run yarn intl:extract and translated the empty ones)
  • Always use French guillemets («») when applicable — it was already done so congrats for that, but some English ones still slipped through
  • Always add an article (le/la/l’) before nouns — those should never be omitted in my opinion, that is never done in other software products unless there are very hard space contraints
  • Use … character instead of three dots
  • Change "Mettre en sourdine" into "Masquer", used in other similar products to translate "Mute"
  • Change other usages of "Masquer" into its synonym "Cacher" to prevent confusion between concepts
  • Shorten "Nouvelle publication" into "Nouv. publication" to prevent it overflowing in the main blue button
  • With the greenlight of @ansh, renamed all occurrences of Publication into Post, that is less mouthful and takes less space in critical UI elements (i.e. the blue button on the left)

It's my first contribution to Bluesky, feel free to tell me if I did something that could have been better for my future contributions :) (I may submit improvements to i18n too, there are some strings that are hard to fix as-is for now because of some string concatenations, so I may suggest some improvements on that later if you are open for those.)

@ansh
Copy link
Contributor

ansh commented Jan 3, 2024

Really appreciate your feedback @Signez ! Till we figure out a formal process for reviewing translations, right now we are just waiting until there is a 2+ native speaker consensus on changes before merging. So, I'll wait till anyone else has anything to chime in here.

@ansh
Copy link
Contributor

ansh commented Jan 3, 2024

Would also love your feedback here #2404 @Signez

We got some professional review on our translation file (I would've sent your changes to be reviewed too but this was last week). Would appreciate your feedback on that PR if you have time.

@@ -1334,7 +1338,11 @@ msgstr "Nouvelle publication"

#: src/view/shell/desktop/LeftNav.tsx:258
msgid "New Post"
msgstr "Nouvelle publication"
msgstr "Nouv. publication"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think this could be translated as "Nouvelle Poste?"

For example, other sites use the french word "Poster" for "Post"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, this could be translated to Nouveau post! (Yeah, post is masculine in French, whereas publication is feminine, so it would be Nouveau and not Nouvelle in that case.)

I didn't want to change publication to post in my pull request because I didn't want, as a first contribution, change all mentions of publications into post — but I think it would be a good call, as users are used to post to refer to it, both in writing and in speaking.

If you don't mind this change, I can make the move from publication to post in that pull request. Waiting for your green light to do so :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that would be great!

Again, want to thank you a lot for your help here. Please add yourself to the "Last-Translator: \n" "Language-Team: \n" header in the messages.po file if you haven't done so already!

@Signez
Copy link
Contributor Author

Signez commented Jan 3, 2024

Would also love your feedback here #2404 @Signez

We got some professional review on our translation file (I would've sent your changes to be reviewed too but this was last week). Would appreciate your feedback on that PR if you have time.

I've just done it! Note that even though I'm not a professional translator, I used to work on a product that spanned several languages ( on a pan-European website selling train tickets), and I helped localize that product, so I'm quite familiar with this kind of endeavor, and the challenges you face. 🤗

Signez added 5 commits January 3, 2024 13:22
- Add missing translations
- Always use French guillemets («») when applicable
- Always add an article (le/la/l’) before nouns
- Use … character instead of three dots
- Change "Mettre en sourdine" into "Masquer", used in other products for "Mute" (and shorter)
- Change other usages of "Masquer" into its synonym "Cacher" to prevent confusion between concepts
- Shorten "Nouvelle publication" into "Nouv. publication" to prevent it overflowing in the main blue button
- Fixed other little errors
@Signez Signez force-pushed the improve-french-localization branch from 26a3631 to a18244b Compare January 3, 2024 12:33
@Signez
Copy link
Contributor Author

Signez commented Jan 3, 2024

This pull request is now rebased, updated with the two new strings extracted from the codebase, and with publication switched with post everywhere (30 substitutions + accords redone, wrt moving from a feminine noun to a masculine one).

Copy link
Contributor

@ansh ansh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging so it does not go stale

@ansh ansh merged commit 7f999d9 into bluesky-social:main Jan 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants