Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hackfix for android splashscreen on api <= 25 (white screen) #2394

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

haileyok
Copy link
Contributor

@haileyok haileyok commented Jan 1, 2024

See: https://bsky.app/profile/sndtrkng.bsky.social/post/3khr3vnm5cm2m

I ran into this while testing a different PR and marked it up as an emulator issue, but it doesn't seem to be. It actually looks like some sort of issue with MaskedView. On platform versions <= 25, the maskElement doesn't seem to work at all. I suspect it is something to do with this: https://github.com/react-native-masked-view/masked-view#androidrenderingmode

Setting that prop to software doesn't help though. I don't think there's a very large number of people on <= 25 so probably this isn't affecting too many users, but there are some. Maybe you can find a better fix 🤷‍♀️

Of note though, it doesn't matter what you set as the mask element. An empty <View /> will cause the issue, so it might not be an animation issue at all. There might be some more info in that repo that could help to resolve it, unsure.

Feel free to merge or not, just wanted to point out the actual problem since I was at first thinking the animation itself needed to be debugged and wasted about 15 minutes trying that.

I'm filing this one under: "what the fuck android, why do you even exist."

@haileyok haileyok changed the title hackfix for android splashscreen hackfix for android splashscreen on api <= 25 (white screen) Jan 1, 2024
@pfrazee pfrazee merged commit cb6e164 into bluesky-social:main Jan 2, 2024
4 checks passed
@pfrazee
Copy link
Collaborator

pfrazee commented Jan 2, 2024

Yeah this is great. Thanks @haileyok !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants