-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding catalan localization #2434
Conversation
Thank you for your submission! Everything looks good, but I'll let this PR sit for a bit until there is some more community interest in taking a second look at the translations. Appreciate your hard work in translating Bluesky! |
Co-authored-by: Dario Castañé <d@rio.hn>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After fixing Dario's commits I can't see any more issues. Congratulations and thanks for this awesome work!
Change Estàs segur to Segur
Talking in voseo form is anachronic, outdated and not recommended in any modern translation style guide. I rather keep the tuteo form as recommended in all style guides. About masculine and feminine forms, you're right, is always better to talk in a neutral form, although it's not yet recognized by the Institut d'Estudis Catalans, so, segur, is the correct official form. That said, it could be replaced by a confirmation, but language needs to be as easy and understanding as possible, so I would go with a simple "Confirmes?, hi estàs d'acord?" For example |
Change "Estàs segur" to "Confirmes" "Ho confirmes" and keep using tuteo
Translation is really good. A did some really minor comments. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding suggestions by @jordimas
Co-authored-by: Dario Castañé <d@rio.hn> Co-authored-by: Daniel Martí <mvdan@mvdan.cc>
With all the revisions, changes and suggestions made by @darccio @jordimas @mvdan @Mejans and @johnnydement we can consider the catalan localization ready. Thanks to everyone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the translation is ready with the changes applied
Wow! That's an incredible work, thanks @ivanbea for kickstarting the localization in Catalan and the first proposal and to everyone else for dedicating their time. I can't wait to use Bluesky in Catalan! |
Thank you everyone! Merging! |
BTW, if somebody has an invitation code I will love it then I can test the translation too |
@jordimas Sent one to your mail! |
Create messages.po in catalan