Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding catalan localization #2434

Merged
merged 7 commits into from
Jan 19, 2024
Merged

Adding catalan localization #2434

merged 7 commits into from
Jan 19, 2024

Conversation

ivanbea
Copy link
Contributor

@ivanbea ivanbea commented Jan 5, 2024

Create messages.po in catalan

@pfrazee pfrazee added the intl Internationalization label Jan 8, 2024
@ansh
Copy link
Contributor

ansh commented Jan 9, 2024

Thank you for your submission! Everything looks good, but I'll let this PR sit for a bit until there is some more community interest in taking a second look at the translations.

Appreciate your hard work in translating Bluesky!

src/locale/locales/ca/messages.po Outdated Show resolved Hide resolved
src/locale/locales/ca/messages.po Outdated Show resolved Hide resolved
src/locale/locales/ca/messages.po Outdated Show resolved Hide resolved
src/locale/locales/ca/messages.po Outdated Show resolved Hide resolved
src/locale/locales/ca/messages.po Outdated Show resolved Hide resolved
src/locale/locales/ca/messages.po Outdated Show resolved Hide resolved
src/locale/locales/ca/messages.po Outdated Show resolved Hide resolved
src/locale/locales/ca/messages.po Outdated Show resolved Hide resolved
src/locale/locales/ca/messages.po Outdated Show resolved Hide resolved
src/locale/locales/ca/messages.po Outdated Show resolved Hide resolved
Co-authored-by: Dario Castañé <d@rio.hn>
Copy link

@johnnydement johnnydement left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After fixing Dario's commits I can't see any more issues. Congratulations and thanks for this awesome work!

Change Estàs segur to Segur
@johnnydement
Copy link

Talking in voseo form is anachronic, outdated and not recommended in any modern translation style guide.

I rather keep the tuteo form as recommended in all style guides.

About masculine and feminine forms, you're right, is always better to talk in a neutral form, although it's not yet recognized by the Institut d'Estudis Catalans, so, segur, is the correct official form.

That said, it could be replaced by a confirmation, but language needs to be as easy and understanding as possible, so I would go with a simple "Confirmes?, hi estàs d'acord?" For example

Change "Estàs segur" to "Confirmes" "Ho confirmes" and keep using tuteo
src/locale/locales/ca/messages.po Show resolved Hide resolved
src/locale/locales/ca/messages.po Outdated Show resolved Hide resolved
src/locale/locales/ca/messages.po Show resolved Hide resolved
src/locale/locales/ca/messages.po Show resolved Hide resolved
src/locale/locales/ca/messages.po Outdated Show resolved Hide resolved
src/locale/locales/ca/messages.po Outdated Show resolved Hide resolved
src/locale/locales/ca/messages.po Outdated Show resolved Hide resolved
src/locale/locales/ca/messages.po Outdated Show resolved Hide resolved
src/locale/locales/ca/messages.po Show resolved Hide resolved
src/locale/locales/ca/messages.po Show resolved Hide resolved
@jordimas
Copy link
Contributor

Translation is really good. A did some really minor comments. Thanks!

Copy link
Contributor Author

@ivanbea ivanbea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply suggested corrections from @jordimas @darccio and @mvdan

src/locale/locales/ca/messages.po Outdated Show resolved Hide resolved
src/locale/locales/ca/messages.po Show resolved Hide resolved
src/locale/locales/ca/messages.po Outdated Show resolved Hide resolved
src/locale/locales/ca/messages.po Show resolved Hide resolved
src/locale/locales/ca/messages.po Show resolved Hide resolved
ivanbea and others added 3 commits January 14, 2024 18:07
adding suggestions by @jordimas
Co-authored-by: Dario Castañé <d@rio.hn>
Co-authored-by: Daniel Martí <mvdan@mvdan.cc>
@ivanbea
Copy link
Contributor Author

ivanbea commented Jan 14, 2024

With all the revisions, changes and suggestions made by @darccio @jordimas @mvdan @Mejans and @johnnydement we can consider the catalan localization ready. Thanks to everyone.

Copy link

@MiquelAdell MiquelAdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the translation is ready with the changes applied

src/locale/locales/ca/messages.po Outdated Show resolved Hide resolved
@ferranrego
Copy link

Wow! That's an incredible work, thanks @ivanbea for kickstarting the localization in Catalan and the first proposal and to everyone else for dedicating their time.

I can't wait to use Bluesky in Catalan!

@pfrazee
Copy link
Collaborator

pfrazee commented Jan 19, 2024

Thank you everyone! Merging!

@pfrazee pfrazee merged commit 0902b4b into bluesky-social:main Jan 19, 2024
4 checks passed
@jordimas
Copy link
Contributor

BTW, if somebody has an invitation code I will love it then I can test the translation too

@darccio
Copy link
Contributor

darccio commented Jan 19, 2024

@jordimas Sent one to your mail!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
intl Internationalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants