Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add from:me search functionality #2504

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

mary-ext
Copy link
Contributor

@mary-ext mary-ext commented Jan 12, 2024

Addresses #849 (comment)
nit: we should probably close that issue already since it's been fixed for a while now

Adds the ability to search for your own posts using the from:me search syntax, this is done by replacing instances of from:me with account's DID, special care is taken to avoid string replacements inside quotes, because quotes are exact search matches

image

@DavidBuchanan314
Copy link
Contributor

By the way, the query parameters are parsed for real as part of the indigo codebase, maybe it would be cleaner to implement the feature there?

https://github.com/bluesky-social/indigo/blob/630059eb1ce90f897527b02612788c05ef95b5e6/search/parse_query.go#L36

I'm not familiar enough with it to say how easy that would be though, obviously the requester's DID needs to be known.

@mary-ext
Copy link
Contributor Author

mary-ext commented Jan 12, 2024

Yeah, that's what I was thinking, I haven't really looked into Palomar directly, thought I'd give it a shot here first.

either AppView or Palomar, but since Palomar is pretty much unauthenticated it might be better to do it in AppView, let's see...

@mary-ext
Copy link
Contributor Author

Here's the alternative AppView PR: bluesky-social/atproto#2044

@pfrazee pfrazee self-assigned this Jan 15, 2024
Copy link
Collaborator

@pfrazee pfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice. The quoted text handling was a nice touch as well

@pfrazee
Copy link
Collaborator

pfrazee commented Jan 23, 2024

I do want to move this into structured query params at some point btw

@pfrazee pfrazee merged commit 68a439d into bluesky-social:main Jan 23, 2024
4 checks passed
@mary-ext
Copy link
Contributor Author

mary-ext commented Jan 29, 2024

I do want to move this into structured query params at some point btw

@pfrazee
ah then I suppose adding a did param to searchPostsSkeleton would be the way to go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants