fix web aux click on all browsers #2633
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2631
fixes #650
Fixes the "aux click" handler to work on all browsers. Currently,
auxclick
support seems to be a bit sketchy: https://developer.mozilla.org/en-US/docs/Web/API/Element/auxclick_event#browser_compatibilityInstead, wrap the
Link
component children inside ofWebAuxClickWrapper
, which adds adiv
withonMouseDown
andonMouseUp
handlers.onMouseDown
prevents the middle click scroll functionality from starting.onMouseUp
checks to make sure the target is not an anchor tag, and if not simulates a meta click on the targeted element. This works on all browsers.Screen.Recording.2024-01-25.at.5.13.05.PM.mov
ts error seems to be unrelated