basic export repository link in settings #2641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolutely no prior React experience, and limited TypeScript, so probably doing all kinds of things wrong! I tried to make it a download button instead of link but that didn't work. There is probably a safer way to construct the URL string. I think having the download open in the browser is reasonable, as opposed to an in-app save flow in mobile. But i'm not sure.
pfrazee
force-pushed
the
bnewbold/export-repo-button
branch
from
eab2639 to
3c6044e
Compare
haileyok
approved these changes
Feb 12, 2024
|
😍 😍 😍 😍 😍 😍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: sneak attack by paul
Absolutely no prior React experience, and limited TypeScript, so probably doing all kinds of things wrong!
I tried to make it a download button instead of link but that didn't work.I got that attribute on there, but my web browser isn't respecting it. We might need to make a specific endpoint that doesn't produce an idiotic filename.There is probably a safer way to construct the URL string.fixedI think having the download open in the browser is reasonable, as opposed to an in-app save flow in mobile. But i'm not sure.
Did not commit the updated translation files (.po)
Final UI pics: