Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Followed version 1.68 of Japanese display #2777

Merged
merged 9 commits into from
Feb 8, 2024

Conversation

Hima-Zinn
Copy link
Contributor

@Hima-Zinn Hima-Zinn commented Feb 7, 2024

@tkusano @dolciss @oboenikui @noritada

The version of the Japanese display has been updated to 1.68, and the update has been made to follow.
One concern is the dark mode setting.
Please refer to this page for the intention of "Dim" and "Dark": #2722 (comment)

@Hima-Zinn
Copy link
Contributor Author

Hima-Zinn commented Feb 7, 2024

@tkusano Thank you.

#: src/view/com/modals/SelfLabel.tsx:95
msgid "Suggestive"
msgstr "きわどい"
photo

@Hima-Zinn
Copy link
Contributor Author

Dim" is set to "グレー".
If "Dim" is set to "薄暗い", it will not match the katakana used in System/Light/Dark, and it will look strange.

Instead, "薄暗い" is indicated in the message displayed in the lower right corner of the window when selected, to supplement the setting.

@Hima-Zinn
Copy link
Contributor Author

By the way, why does the "Lint / Run linters (pull_request)" check throw an error?
I don't think anything strange has been done, so I hope it will be fixed when the merge is done.

@Hima-Zinn
Copy link
Contributor Author

@pfrazee
Copy link
Collaborator

pfrazee commented Feb 8, 2024

By the way, why does the "Lint / Run linters (pull_request)" check throw an error? I don't think anything strange has been done, so I hope it will be fixed when the merge is done.

A mistake we introduced, don't worry about it!

Copy link
Collaborator

@pfrazee pfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thanks all!

@pfrazee pfrazee merged commit 80c482b into bluesky-social:main Feb 8, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants