Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Indonesian ID translation to latest #2803

Merged
merged 9 commits into from
Apr 3, 2024

Conversation

danninov
Copy link
Contributor

@danninov danninov commented Feb 8, 2024

Add more Indonesian translation for 1.68.

@danninov danninov changed the title Update Indonesian translation for 1.68 Update ID translation for 1.68 Feb 8, 2024
@pfrazee
Copy link
Collaborator

pfrazee commented Feb 8, 2024

Thanks @danninov ! Can someone else in the community confirm these?

@pfrazee pfrazee added intl Internationalization intl-needs-confirmation Submitted internationalization that needs confirmations by native speakers. labels Feb 8, 2024
@thinkbyte1024
Copy link

thinkbyte1024 commented Feb 9, 2024

Should we change all the word feeds into umpan? I think there was already an inconsistency within the previous PR.

EDIT: What I meant is, that there was already a word umpan somewhere in this file. So, either change it to umpan or something else.

@danninov
Copy link
Contributor Author

Should we change all the word feeds into umpan? I think there was already an inconsistency within the previous PR.

EDIT: What I meant is, that there was already a word umpan somewhere in this file. So, either change it to umpan or something else.

I can only find one "Umpan" word, but I guess this issue will continue to come up unless we all agree which the best way to handle it.

@thinkbyte1024
Copy link

thinkbyte1024 commented Feb 10, 2024

Yes, I agree. But, as for my previous statement in PR #2554, I would consider changing it due to our pronunciation is different than the English one.

We can gather more consensus on this issue for now, if many Indonesian users (with high knowledge of linguistics) can come and help with this PR.

Copy link

@thinkbyte1024 thinkbyte1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated my review with some changes. The word following should be translated to mengikuti to match last translation.

src/locale/locales/id/messages.po Outdated Show resolved Hide resolved
src/locale/locales/id/messages.po Outdated Show resolved Hide resolved
src/locale/locales/id/messages.po Outdated Show resolved Hide resolved
src/locale/locales/id/messages.po Outdated Show resolved Hide resolved
src/locale/locales/id/messages.po Outdated Show resolved Hide resolved
src/locale/locales/id/messages.po Outdated Show resolved Hide resolved
src/locale/locales/id/messages.po Outdated Show resolved Hide resolved
src/locale/locales/id/messages.po Outdated Show resolved Hide resolved
Copy link
Contributor

@kodebanget kodebanget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, I'm suggesting a few changes below. Other than that, this translation looks good.

src/locale/locales/id/messages.po Outdated Show resolved Hide resolved
src/locale/locales/id/messages.po Outdated Show resolved Hide resolved
src/locale/locales/id/messages.po Outdated Show resolved Hide resolved
src/locale/locales/id/messages.po Outdated Show resolved Hide resolved
src/locale/locales/id/messages.po Outdated Show resolved Hide resolved
src/locale/locales/id/messages.po Outdated Show resolved Hide resolved
danninov and others added 2 commits February 18, 2024 12:08
Co-authored-by: Fafin <151415765+kodebanget@users.noreply.github.com>
Co-authored-by: Aditya Dirgantara <ccoremapd@icloud.com>
@danninov
Copy link
Contributor Author

Hi @kodebanget @thinkbyte1024,

Thanks for the input. I've commited the changes that you're suggest. Thanks.

Co-authored-by: Aditya Dirgantara <ccoremapd@icloud.com>
Copy link

@thinkbyte1024 thinkbyte1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 2717 needs an action. We can change the word umpan back to feed, for now.

I'll figure this word out, in the next PR.

@danninov
Copy link
Contributor Author

Line 2717 needs an action. We can change the word umpan back to feed, for now.

I'll figure this word out, in the next PR.

Sure, I've changed it to Feed. Let's ask to ID language expert how the best way to tackle this. Thanks.

@thinkbyte1024
Copy link

Alright, looks good to me. 👍

Copy link
Contributor

@kodebanget kodebanget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re: "feed", it's tricky since what @thinkbyte1024 said about the pronunciation makes sense but the word "feed" is already widely used colloquially among Indonesians, therefore makes it easier to understand that "umpan" in the context of social platforms. If it helps a bit, Google uses "feed" in their Indonesian glossary (https://support.google.com/search?q=feed&hl=id). I think we can keep using "feed" for now.

@oops-wtf and I have set up a Crowdin project for this translation to help with our collaboration going forward. Hopefully more people would be able to contribute, vote, and join the discussion so we can reach a consensus.

@danninov
Copy link
Contributor Author

I think we can merge this PR @pfrazee

@danninov danninov changed the title Update ID translation for 1.68 Update ID translation to latest Mar 7, 2024
@danninov danninov changed the title Update ID translation to latest Update Indonesian ID translation to latest Mar 8, 2024
@pfrazee
Copy link
Collaborator

pfrazee commented Apr 3, 2024

Thanks everyone!!

@pfrazee pfrazee merged commit 02b2ab4 into bluesky-social:main Apr 3, 2024
5 checks passed
@danninov danninov deleted the update-id-translation-1.68 branch May 27, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
intl Internationalization intl-needs-confirmation Submitted internationalization that needs confirmations by native speakers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants