-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Indonesian ID translation to latest #2803
Update Indonesian ID translation to latest #2803
Conversation
Thanks @danninov ! Can someone else in the community confirm these? |
Should we change all the word EDIT: What I meant is, that there was already a word |
I can only find one "Umpan" word, but I guess this issue will continue to come up unless we all agree which the best way to handle it. |
Yes, I agree. But, as for my previous statement in PR #2554, I would consider changing it due to our pronunciation is different than the English one. We can gather more consensus on this issue for now, if many Indonesian users (with high knowledge of linguistics) can come and help with this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated my review with some changes. The word following
should be translated to mengikuti
to match last translation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, I'm suggesting a few changes below. Other than that, this translation looks good.
Co-authored-by: Fafin <151415765+kodebanget@users.noreply.github.com> Co-authored-by: Aditya Dirgantara <ccoremapd@icloud.com>
Hi @kodebanget @thinkbyte1024, Thanks for the input. I've commited the changes that you're suggest. Thanks. |
Co-authored-by: Aditya Dirgantara <ccoremapd@icloud.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 2717 needs an action. We can change the word umpan
back to feed
, for now.
I'll figure this word out, in the next PR.
Sure, I've changed it to Feed. Let's ask to ID language expert how the best way to tackle this. Thanks. |
Alright, looks good to me. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re: "feed", it's tricky since what @thinkbyte1024 said about the pronunciation makes sense but the word "feed" is already widely used colloquially among Indonesians, therefore makes it easier to understand that "umpan" in the context of social platforms. If it helps a bit, Google uses "feed" in their Indonesian glossary (https://support.google.com/search?q=feed&hl=id). I think we can keep using "feed" for now.
@oops-wtf and I have set up a Crowdin project for this translation to help with our collaboration going forward. Hopefully more people would be able to contribute, vote, and join the discussion so we can reach a consensus.
I think we can merge this PR @pfrazee |
Thanks everyone!! |
Add more Indonesian translation for 1.68.