-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bskyweb additions #296
bskyweb additions #296
Conversation
…b Actions for container push to ghcr/aws
575a059
to
770240f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'll want to automate the hash/commit-in-JS-filename, but can do that in a follow-up PR. I like the templates baked-in, not sure we'll want the (large!) JS bundle in there also, but fine for now.
LGTM!
Need to figure out the CI issue though, and CI should also be running after merging to main (looks like that isn't happening right now?). I think you may just need to add some entries to |
Sorry I've been slow to respond, just getting out of the swamp. @Jacob2161 Mailmodo looks right to me. All looking good -- my one question is about the deploy trigger. Right now "main" isn't a safe trigger, so we either need to introduce a dev branch for active work, introduce a "deploy" branch for triggering pushes, or use some other kind of trigger (tags?). Open to ideas here; just need a strong and clear control over the deploy trigger. @bnewbold I haven't double checked but I'm pretty sure that the expo js-build script is giving the js files unique names per build, which is why I had the post-build script which wrote the scripts template with the latest buildfile names. It's probably correct to remove the scripts template from the repo because it'll change on every build? But if that's the goal we probably need to gitignore it, but make sure it's still being used (at a glance I'm not sure if this PR preserved that). |
Add some minor bskyweb improvements, Mailmodo endpoint, Dockerfile for bskyweb, container image push
POST
/waitlist
withemail
parameter. Should anything change here @pfrazee?--http-server=:1234
for setting HTTP listen address.templates/*
andstatic/*