Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bskyweb additions #296

Merged
merged 10 commits into from
Mar 20, 2023
Merged

bskyweb additions #296

merged 10 commits into from
Mar 20, 2023

Conversation

Jacob2161
Copy link
Contributor

@Jacob2161 Jacob2161 commented Mar 16, 2023

  1. Added Mailmodo waitlist API endpoint: POST /waitlist with email parameter. Should anything change here @pfrazee?
  2. Added --http-server=:1234 for setting HTTP listen address.
  3. Added binary embedded templates/* and static/*
  4. Added Dockerfile
  5. GitHub Actions for GitHub and AWS (will need to change auth for this again)

@Jacob2161 Jacob2161 force-pushed the jake/bskyweb-additions branch from 575a059 to 770240f Compare March 16, 2023 03:56
@Jacob2161 Jacob2161 requested a review from bnewbold March 16, 2023 03:58
Copy link
Contributor

@bnewbold bnewbold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll want to automate the hash/commit-in-JS-filename, but can do that in a follow-up PR. I like the templates baked-in, not sure we'll want the (large!) JS bundle in there also, but fine for now.

LGTM!

@bnewbold
Copy link
Contributor

Need to figure out the CI issue though, and CI should also be running after merging to main (looks like that isn't happening right now?).

I think you may just need to add some entries to .prettierignore

@pfrazee
Copy link
Collaborator

pfrazee commented Mar 20, 2023

Sorry I've been slow to respond, just getting out of the swamp.

@Jacob2161 Mailmodo looks right to me. All looking good -- my one question is about the deploy trigger. Right now "main" isn't a safe trigger, so we either need to introduce a dev branch for active work, introduce a "deploy" branch for triggering pushes, or use some other kind of trigger (tags?). Open to ideas here; just need a strong and clear control over the deploy trigger.

@bnewbold I haven't double checked but I'm pretty sure that the expo js-build script is giving the js files unique names per build, which is why I had the post-build script which wrote the scripts template with the latest buildfile names. It's probably correct to remove the scripts template from the repo because it'll change on every build? But if that's the goal we probably need to gitignore it, but make sure it's still being used (at a glance I'm not sure if this PR preserved that).

@Jacob2161 Jacob2161 merged commit a4cadfe into main Mar 20, 2023
@Jacob2161 Jacob2161 deleted the jake/bskyweb-additions branch March 20, 2023 21:41
pfrazee pushed a commit that referenced this pull request Apr 3, 2023
Add some minor bskyweb improvements, Mailmodo endpoint, Dockerfile for bskyweb, container image push
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants