Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NicoVideo inline play #3303

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

haoyayoi
Copy link

Support nicovideo.jp in embed target. Autoplay not support.

Target Host:

pr_preview_1
pr_preview_2
pr_preview_3

@haileyok haileyok self-requested a review March 21, 2024 14:53
@haileyok
Copy link
Contributor

@haoyayoi Thanks for cleaning those up, I'll review it here later today probably.

@haileyok
Copy link
Contributor

Screenshot 2024-03-21 at 10 48 38 AM

Hi! I just merged in main and added a few small changes. This is great! One question about the image above. Have you tested this on web to see if it works for you? I can't find any good documentation on their embed API so not sure if that's something that would be fixed on a non-localhost server or if we'd need to host an embed frame for this.

Thanks!

@haoyayoi
Copy link
Author

I tried this on html like youtube(bskyweb/static/iframe/youtube.html), reference https://qiita.com/fanta_/items/13e0819e0c1db111186c. But blocked web and ios
on localhost. So, change to react-native-webview.

Nicovideo chief developer has account in Bluesky, it might be a good idea to check.

thank you

@haoyayoi
Copy link
Author

The cause of the error is probably CORS.

@haileyok
Copy link
Contributor

Hey! Do you know the handle of the Nicovideo dev? I'll send them a mention to see if we can clear this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants