Allow text selection of the post being replied to in composer #3346
+35
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mozzius
reviewed
Apr 2, 2024
| @@ -100,7 +110,8 @@ export function ComposerReplyTo({replyTo}: {replyTo: ComposerOptsPostRef}) { | |||
| <Text | |||
| type="post-text" | |||
| style={pal.text} | |||
| numberOfLines={!showFull ? 6 : undefined}> | |||
| numberOfLines={!showFull ? 6 : undefined} | |||
| selectable> | |||
There was a problem hiding this comment.
Should it be a selectable uitextview? Would that cause issues?
There was a problem hiding this comment.
This <Text> does that underneath in
(Reminds me though that we can also merge this in #3090, has a few fixes that came up from other people using it)
There was a problem hiding this comment.
Ah my bad, should've checked that :)
|
Tested on iOS and Android, works well. But I think the letter spacing changed on iOS? or maybe the font weight or the aliasing or something?
|
|
Oh interesting. Looks like it's that way in prod as well. Let me see if I can just hit that real quick here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Users frequently want to be able to pull a piece of text out of the post they are replying to. By adding the
selectableprop to theComposerReplyTo'sText, we can easily allow users to do this.We also need to add a dummy callback to the
onLongPresshere so that thePressabledoes not interfere with the native press and hold to select.