android: fix various places still using default Material Teal #3555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kisaragi-hiu
force-pushed
the
android-accent-color
branch
3 times, most recently
from
6177c7a
to
5073606
Compare
|
Another awesome PR! I'll test this out later this week, but looks solid! ❤️ |
These places include TextInput cursor, TextInput selection, and the spinner (ActivityIndicator) --- the default Material Teal is out of place wherever it shows up. This sets Expo's primaryColor to #1083fe, which is the color that defaultTheme.palette.default.brandText resolves to, then applies it as the native accent color via a plugin because Expo doesn't apply the accent color.
kisaragi-hiu
force-pushed
the
android-accent-color
branch
from
5073606
to
da32982
Compare
haileyok
approved these changes
Apr 29, 2024
estrattonbailey
added a commit
that referenced
this pull request
May 1, 2024
* origin/main: (39 commits) [Clipclops] Separate messages if there's a time gap (#3777) [Clipclops] Header for chat (#3775) [Clipclops] adjust scroll position, keyboard color (#3771) [Clipclops] Add clop sent time to clipclop (#3772) [Clipclops] Use API data for clipclop list (#3769) [Clipclops] New clipclop dialog (#3750) Session fixes, pt. 1 (#3762) use keyboardDismissMode rather than onScrollBeginDrag (#3767) [Clipclops] Add screen to view and send clip clops (#3754) switch branch for installing `react-native-bottom-sheet` (#3760) Fix List onMomentumScrollEnd (#3759) Release 1.80 (#3757) Update zh-TW translations (#3678) Italian localization (#3684) Update catalan messages.po (#3697) Update Korean localization (#3698) Update Japanese translation (#3734) Update zh-CN translations (#3716) Send Bluesky feeds and suggested follows more data (#3695) android: fix various places still using default Material Teal (#3555) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some places on Android are currently using the default Material Teal color, including the TextInput cursor, TextInput selection, and the spinner (ActivityIndicator) --- it's quite out of place whenever it shows up.
This PR sets Expo's primaryColor to #1083fe (which is the color that defaultTheme.palette.default.brandText resolves to), then applies it as the native accent color via a plugin (because Expo doesn't apply the accent color).
Comparison:
The
plugins/withAndroidStylesAccentColorPlugin.jsplugin is copied and modified fromplugins/withAndroidStylesWindowBackgroundPlugin.jssince that appears to be the idiomatic way of modifying Android'sres/values/styles.xml.