Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send Bluesky feeds and suggested follows more data #3695

Merged
merged 8 commits into from
Apr 29, 2024
Merged

Conversation

estrattonbailey
Copy link
Member

@estrattonbailey estrattonbailey commented Apr 24, 2024

This PR sends Accept-Language to getSuggestions, and sends the interests collected during onboarding along with requests to getSuggestions and to getFeed using a header.

This data will only be shared with feeds owned and/or managed by Bluesky, for the same reasons outlined in #3498. When we have a better permissions model in place, the intention is provide feeds with the data they need to create a good experience.

Copy link

render bot commented Apr 24, 2024

Copy link

github-actions bot commented Apr 24, 2024

Old size New size Diff
6.44 MB 6.44 MB 1.9 KB (0.03%)

@estrattonbailey estrattonbailey changed the title WIP header tweaks Send Bluesky feeds and suggested follows more data Apr 25, 2024
* origin/main:
  embedr: handle out-of-range maxwidth; change default (#3713)
  Move Notifications up on desktop web (#3696)
  [Session] Add `useAgent` hook and replace (#3706)
  [Session] Drill `getAgent` into notifications handlers (#3705)
  [Session] Drill `getAgent` into `Onboarding/util` (#3704)
  [Session] Drill `getAgent` into `notifications/utils` (#3703)
  [Session] Drill into `getAgent` into `whenAppViewReady` (#3702)
  [Session] Drill `getAgent` into feed APIs (#3701)
  Irish translation back to 100% (#3683)
  [Session] Base (#3541)
  remove use of `pointerEvents` on iOS profile header (#3694)
  Cleanup files after each iteration of compression and downloading (#3599)
estrattonbailey and others added 2 commits April 28, 2024 15:31
* origin:
  Fix dropdown immediately closing on Enter (#3745)
  Account for momentum when hiding minimal shell (#3740)
  Reduce hovercard false positives, add them to display names and handles (#3739)
  YouTube Music as supported player (#3736)
  Patch lexicon for perf (#3733)
  ensure dialog is closed on unmount (#3650)
  remove precacheThreadPostProfiles (#3729)
  [Clipclops] New routes with placeholder screens (#3725)
  Special-case bsky.app/download to open share sheet or copy to clipboard (#3710)
  ver bump (#3731)
  Improve usability of search on web (#3663)
Copy link
Collaborator

@pfrazee pfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaearon gaearon merged commit a4e3453 into main Apr 29, 2024
6 checks passed
@gaearon gaearon deleted the send-interests branch April 29, 2024 21:04
estrattonbailey added a commit that referenced this pull request May 1, 2024
* origin/main: (39 commits)
  [Clipclops] Separate messages if there's a time gap (#3777)
  [Clipclops] Header for chat (#3775)
  [Clipclops] adjust scroll position, keyboard color (#3771)
  [Clipclops] Add clop sent time to clipclop (#3772)
  [Clipclops] Use API data for clipclop list (#3769)
  [Clipclops] New clipclop dialog (#3750)
  Session fixes, pt. 1 (#3762)
  use keyboardDismissMode rather than onScrollBeginDrag (#3767)
  [Clipclops] Add screen to view and send clip clops (#3754)
  switch branch for installing `react-native-bottom-sheet` (#3760)
  Fix List onMomentumScrollEnd (#3759)
  Release 1.80 (#3757)
  Update zh-TW translations (#3678)
  Italian localization (#3684)
  Update catalan messages.po (#3697)
  Update Korean localization (#3698)
  Update Japanese translation (#3734)
  Update zh-CN translations (#3716)
  Send Bluesky feeds and suggested follows more data (#3695)
  android: fix various places still using default Material Teal (#3555)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants