[Clipclops] New clipclop dialog #3750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mozzius
force-pushed
the
samuel/new-chat
branch
from
8ba95fb to
38a46b1
Compare
|
# Conflicts: # src/screens/Messages/Conversation/index.tsx # src/screens/Messages/List/index.tsx # src/screens/Messages/Settings/index.tsx # src/view/shell/bottom-bar/BottomBar.tsx # src/view/shell/bottom-bar/BottomBarWeb.tsx # src/view/shell/desktop/LeftNav.tsx
mozzius
force-pushed
the
samuel/new-chat
branch
from
be1c11f to
309e444
Compare
# Conflicts: # src/screens/Messages/Conversation/MessagesList.tsx # src/screens/Messages/Conversation/RandomClipClops.ts # src/screens/Messages/Temp/query/query.ts
# Conflicts: # src/screens/Messages/Conversation/MessageItem.tsx # src/screens/Messages/Conversation/MessagesList.tsx # src/screens/Messages/Temp/query/query.ts
|
Your Render PR Server URL is https://social-app-pr-3750.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-coo935icn0vc738ov1d0. |
haileyok
reviewed
Apr 30, 2024
haileyok
reviewed
Apr 30, 2024
haileyok
reviewed
Apr 30, 2024
| ) | ||
| } | ||
|
|
||
| return ( | ||
| <View> | ||
| <View style={a.flex_1}> |
There was a problem hiding this comment.
Here I think we want CenteredView with sideBorders. (Pretty sure it still needs flex: 1)
There was a problem hiding this comment.
This has a bunch of problems unfortunately, doesn't work on iPad.
There was a problem hiding this comment.
Oh well that's not good...now i'm curious how it looks everywhere else in the app 😳
|
No new chat button on web when on the desktop breakpoint. 
|
|
So stoked for this!! Tested it out again tonight and was able to talk to myself from native and web 😆 |
|
Fixed the desktop breakpoint, I think it's ready to go |
haileyok
approved these changes
Apr 30, 2024
estrattonbailey
added a commit
that referenced
this pull request
May 1, 2024
* origin/main: (39 commits) [Clipclops] Separate messages if there's a time gap (#3777) [Clipclops] Header for chat (#3775) [Clipclops] adjust scroll position, keyboard color (#3771) [Clipclops] Add clop sent time to clipclop (#3772) [Clipclops] Use API data for clipclop list (#3769) [Clipclops] New clipclop dialog (#3750) Session fixes, pt. 1 (#3762) use keyboardDismissMode rather than onScrollBeginDrag (#3767) [Clipclops] Add screen to view and send clip clops (#3754) switch branch for installing `react-native-bottom-sheet` (#3760) Fix List onMomentumScrollEnd (#3759) Release 1.80 (#3757) Update zh-TW translations (#3678) Italian localization (#3684) Update catalan messages.po (#3697) Update Korean localization (#3698) Update Japanese translation (#3734) Update zh-CN translations (#3716) Send Bluesky feeds and suggested follows more data (#3695) android: fix various places still using default Material Teal (#3555) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #3754 and #3749
Need to figure out what the initial page looks like when there's no search term