Fix List onMomentumScrollEnd #3759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-3759.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-coo20j0l6cac73fnouog. |
pfrazee
approved these changes
Apr 29, 2024
|
estrattonbailey
added a commit
that referenced
this pull request
May 1, 2024
* origin/main: (39 commits) [Clipclops] Separate messages if there's a time gap (#3777) [Clipclops] Header for chat (#3775) [Clipclops] adjust scroll position, keyboard color (#3771) [Clipclops] Add clop sent time to clipclop (#3772) [Clipclops] Use API data for clipclop list (#3769) [Clipclops] New clipclop dialog (#3750) Session fixes, pt. 1 (#3762) use keyboardDismissMode rather than onScrollBeginDrag (#3767) [Clipclops] Add screen to view and send clip clops (#3754) switch branch for installing `react-native-bottom-sheet` (#3760) Fix List onMomentumScrollEnd (#3759) Release 1.80 (#3757) Update zh-TW translations (#3678) Italian localization (#3684) Update catalan messages.po (#3697) Update Korean localization (#3698) Update Japanese translation (#3734) Update zh-CN translations (#3716) Send Bluesky feeds and suggested follows more data (#3695) android: fix various places still using default Material Teal (#3555) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot that passing Reanimated handlers breaks built-in event handler properties on
FlatList. So because I started passing inonMomentumEndin the Reanimated handler, the built-inonMomentumScrollEndwas no longer being called.The fix is to add it to the denylist we already have (which currently has
onScrollin it). I've added the other related events there too so that we don't run into this again.Then we use the existing
<ScrollContext>to pass the contextual handler to theList. On this page it doesn't need to compose with anything because there's no top-level scroll context.Review
Review without whitespace
Test Plan
No effect on the web — that event isn't wired up there. We don't need it on the web either.
iOS and Android are now able to load a long thread upwards.
iosios.mov
anrdoi.mov