Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Japanese translation #3557

Merged
merged 5 commits into from
Apr 18, 2024
Merged

Conversation

tkusano
Copy link
Contributor

@tkusano tkusano commented Apr 15, 2024

Remove obsoleted entries only. No new translations are added yet.

@tkusano tkusano changed the title Remove obsoleted entries Update Japanese translation Apr 15, 2024
@tkusano
Copy link
Contributor Author

tkusano commented Apr 16, 2024

New message translations have been added. Please check the following diffs (there was a typo in the first one, corrected in the second one)

新しいメッセージの翻訳を追加しました。新規翻訳については以下の差分で見ることができます(1つ目でタイプミスがあったので2つ目で修正)。

7134567
5c6df13

@tkusano
Copy link
Contributor Author

tkusano commented Apr 16, 2024

翻訳の補足です

#: src/components/ProfileHoverCard/index.web.tsx:314
msgid "<0>{followers} </0><1>{pluralizedFollowers}</1>"
msgstr "<0>{followers} </0><1>フォロワー</1>"

ウェブでアバターの上にカーソルを持って行った時に表示される小さな画面に表示。{pluralizedFollowers}は英語だとfollowerまたはfollowersに変化する文字列ですが、日本語なので「フォロワー」のみに固定

#: src/components/dialogs/Embed.tsx:134
msgid "Copied!"
msgstr "コピーしました!"

#: src/components/dialogs/Embed.tsx:120
#: src/components/dialogs/Embed.tsx:139
msgid "Copy code"
msgstr "コードをコピー"

#: src/components/dialogs/Embed.tsx:112
msgid "Embed HTML code"
msgstr "HTMLコードを埋め込む"

#: src/components/dialogs/Embed.tsx:97
#: src/view/com/util/forms/PostDropdownBtn.tsx:253
#: src/view/com/util/forms/PostDropdownBtn.tsx:255
msgid "Embed post"
msgstr "投稿を埋め込む"

#: src/components/dialogs/Embed.tsx:101
msgid "Embed this post in your website. Simply copy the following snippet and paste it into the HTML code of your website."
msgstr "この投稿をあなたのウェブサイトに埋みます。以下のスニペットをコピーして、あなたのウェブサイトのHTMLコードに貼り付けるだけです。"

HTMLコードの埋め込みダイアログに表示されたりするものです

#: src/view/com/posts/FeedItem.tsx:216
msgid "Reposted by <0><1/></0>"
msgstr "<0><1/></0>がリポスト"

フィードに流れてくるリポストの上に表示される「Reposted by...」の部分です

#: src/view/com/notifications/FeedItem.tsx:419
#: src/view/com/util/UserAvatar.tsx:381
msgid "See profile"
msgstr "プロフィールを表示"

アバターに設定されるaria-labelです

#: src/components/dialogs/Signin.tsx:75
msgid "Sign in or create your account to join the conversation!"
msgstr "会話に参加するにはサインインするか新しくアカウントを登録してください!"

ログインせずにbsky.appにアクセスした時に表示されるフィード中の投稿の返信ボタンをクリックした時に出るダイアログに表示されるメッセージ

#: src/components/dialogs/Signin.tsx:46
msgid "Sign into Bluesky or create a new account"
msgstr "Blueskyにサインイン、または、新規アカウントの登録"

上記ダイアログのaria-label

@tkusano tkusano closed this Apr 16, 2024
@tkusano tkusano reopened this Apr 16, 2024
@tkusano tkusano marked this pull request as ready for review April 16, 2024 23:16
@tkusano
Copy link
Contributor Author

tkusano commented Apr 16, 2024

@Hima-Zinn @dolciss @oboenikui @noritada @middlingphys @hibiki @reindex-ot @haoyayoi @vyv03354

レビューおねがいします
Please review

Copy link
Contributor

@Hima-Zinn Hima-Zinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good.
Particularly, I would be glad to see it done, as deleting unused translation sections is necessary for the translation work to continue in the future.

@tkusano
Copy link
Contributor Author

tkusano commented Apr 18, 2024

  • e3628ef merge changes in main (no translation update) : mainをマージ (翻訳の更新無し)
  • b8f7a2d update translation to sync with main : mainの変更に追従して翻訳を更新
    • Remove "add link card" related translation (caused by 046e11d) : リンクカードが自動的に追加されるようになったので関連翻訳対象が消えた
    • 'Reply to ...' msgid has been changed (caused by 480fa10) : 返信投稿の頭の「〜に返信」の原文のコードが変わったことによるマークアップの変更に追従

@dolciss
Copy link
Contributor

dolciss commented Apr 18, 2024

Thank you for presenting the commitments for the reason for the change!
LTGM

Copy link
Collaborator

@pfrazee pfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks all!

@pfrazee pfrazee merged commit 2090738 into bluesky-social:main Apr 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants