Improve search screen perf #3752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only ever useful if you type it exactly correct. Search now does a better job anyway.
|
Your Render PR Server URL is https://social-app-pr-3752.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-conrkdmg1b2c73dp1go0. |
|
geobde
reviewed
May 2, 2024
| @@ -850,6 +864,7 @@ function AutocompleteResults({ | |||
| </> | |||
| ) | |||
| } | |||
| AutocompleteResults = React.memo(AutocompleteResults) | |||
There was a problem hiding this comment.
@gaearon why you dont just wrap the component with memo?
maybe I'm missing some context
There was a problem hiding this comment.
would need a Babel plugin to keep function names readable without adding an extra indentation level due to writing them twice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first few commits extract components with no changes to their logic and add some
memos.The main real change is e46aac2. It renders both the autocomplete and the result list so that switching between those is less laggy. This is especially noticeable on iOS.
Finally, there's a few drive-by changes. 16a13c5 removes subdomain matching — it is not very useful now that we properly rank results, and it looks a bit out-of-place in the list. Also, 36485ea adds some missing hitslops to the recent searches.
Test Plan
The usual for this screen.
bla.mov