Hide search suggestion on clicking outside search field

[joonmo-you]

The current behavior, as @gaearon mentioned here, allows the search suggestion open even when clicking outside the search field. Implementing an event handler for blurring would resolve this issue temporarily. Additionally, I concur with the suggestion to evolve the search suggestion into a popover.

[gaearon]

Doing this on blur wouldn't be sufficient because that would break it for keyboard users. Need to be able to navigate the list with keyboard without having it disappear.

[joonmo-you]

Doing this on blur wouldn't be sufficient because that would break it for keyboard users. Need to be able to navigate the list with keyboard without having it disappear.

I was naive, overlooking users who navigate using a keyboard. I resolved the issue by addressing two scenarios: Firstly, ensuring the search field remains open when focused elements remain within it. Secondly, closing the search field when focus shifts outside of it, either by clicking elsewhere or navigating away using the keyboard.

[joonmo-you]

2024-05-01.9.11.46.mov

[zidanegimiga]

Hey @joonmo-you, were you also adding user's search history there. Referencing issue #3859

[joonmo-you]

Hey @joonmo-you, were you also adding user's search history there. Referencing issue #3859

I've just been through the issue you referred to. I am not sure the issue should be discussed here. I think the features related to search history would be better addressed separately.

[pfrazee]

Thanks so much @joonmo-you for handling the requested change. It seems to work exactly right. @gaearon you good w/this?