Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications not removed when they are read in the app #3768

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Notifications not removed when they are read in the app #3768

wants to merge 2 commits into from

Conversation

omar0404
Copy link

@mary-ext
Copy link
Contributor

mary-ext commented Apr 30, 2024 •
edited
Loading

This seems like the wrong approach? It only makes sense if the notification occured very recently. If there are multiple unread notifications you'd risk marking them all as read, and you'd have no idea which one is new.

@omar0404
Copy link
Author

omar0404 commented Apr 30, 2024 •
edited
Loading

@mary-ext i thought since we are switching to notifications tab (here) this means user read all of them. i think facebook works this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omar0404 @mary-ext