Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Clipclops] Dynamic input height #3778

Merged
merged 14 commits into from
May 1, 2024
Merged

Conversation

haileyok
Copy link
Contributor

@haileyok haileyok commented Apr 30, 2024

I'm adding one new package here for web react-textarea-autoresize. If anyone has a good idea on how to do this on web w/o the library that would be fine too. Seems to be quite a pain to get right though and to maintain accessibility.

iOS

RocketSim_Recording_iPhone_15_Pro_6 1_2024-04-30_17 37 27

Android

Screen.Recording.2024-04-30.at.5.36.50.PM.mov

Web

The first messages are me just hitting Enter. The subsequent new lines are me pressing Shift + Enter

Screen.Recording.2024-04-30.at.5.39.03.PM.mov

Copy link

render bot commented Apr 30, 2024

Copy link

github-actions bot commented Apr 30, 2024

Old size New size Diff
6.84 MB 6.84 MB 46 B (0.00%)

Copy link

github-actions bot commented May 1, 2024

The Pull Request introduced fingerprint changes against the base commit: 6f9993c

Fingerprint diff
[{"type":"file","filePath":"package.json","reasons":["expoConfigPlugins"],"hash":"915b71c379e0c52de513769fadb75dd1fe0cd2c2"}]

Generated by PR labeler 🤖

@haileyok haileyok marked this pull request as ready for review May 1, 2024 01:21
@haileyok haileyok requested a review from mozzius May 1, 2024 01:35
@mozzius mozzius force-pushed the hailey/mesage-input-multiline branch from 0815135 to f5acc5f Compare May 1, 2024 17:46
Copy link
Member

@mozzius mozzius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added trimming, lg

@mozzius mozzius merged commit 333ccda into main May 1, 2024
6 checks passed
@mozzius mozzius deleted the hailey/mesage-input-multiline branch May 1, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants