-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Clipclops] Dynamic input height #3778
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your Render PR Server URL is https://social-app-pr-3778.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cooni6gl6cac739rtrhg. |
|
The Pull Request introduced fingerprint changes against the base commit: 6f9993c Fingerprint diff[{"type":"file","filePath":"package.json","reasons":["expoConfigPlugins"],"hash":"915b71c379e0c52de513769fadb75dd1fe0cd2c2"}] Generated by PR labeler 🤖 |
mozzius
force-pushed
the
hailey/mesage-input-multiline
branch
from
May 1, 2024 17:46
0815135
to
f5acc5f
Compare
mozzius
approved these changes
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added trimming, lg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding one new package here for web
react-textarea-autoresize
. If anyone has a good idea on how to do this on web w/o the library that would be fine too. Seems to be quite a pain to get right though and to maintain accessibility.iOS
Android
Screen.Recording.2024-04-30.at.5.36.50.PM.mov
Web
The first messages are me just hitting Enter. The subsequent new lines are me pressing Shift + Enter
Screen.Recording.2024-04-30.at.5.39.03.PM.mov