🚧 XRPC rework #3814
Draft
🚧 XRPC rework #3814
+200
−158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-3814.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-copnj8tjm4es73efeaqg. |
Closed
matthieusieben
force-pushed
the
xrpc-rework
branch
2 times, most recently
from
b72440f to
7c9f2cd
Compare
|
matthieusieben
force-pushed
the
xrpc-rework
branch
from
7c9f2cd to
ae00556
Compare
matthieusieben
changed the base branch from
dx-atproto-modules
to
fix-mobile-car-download
matthieusieben
commented
May 2, 2024
src/lib/link-meta/link-meta.ts
Outdated
| const response = await fetch( | ||
| `${LINK_META_PROXY(agent.service.toString() || '')}${encodeURIComponent( | ||
| `${LINK_META_PROXY(serciceUrl.toString() || '')}${encodeURIComponent( |
There was a problem hiding this comment.
Is there a way we could do this without having to have access to the .getServiceUrl ? This is the only place this method (from @atproto/api) is needed for.
matthieusieben
force-pushed
the
fix-mobile-car-download
branch
from
7187def to
99d7966
Compare
matthieusieben
force-pushed
the
xrpc-rework
branch
from
ae00556 to
1a535b0
Compare
matthieusieben
force-pushed
the
fix-mobile-car-download
branch
from
99d7966 to
7b15c8d
Compare
matthieusieben
force-pushed
the
xrpc-rework
branch
from
1a535b0 to
24bf6f8
Compare
matthieusieben
force-pushed
the
xrpc-rework
branch
from
24bf6f8 to
99f74f4
Compare
matthieusieben
force-pushed
the
xrpc-rework
branch
from
99f74f4 to
a053710
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adapts the social-app to the changes introduced by bluesky-social/atproto#2434
This PR should not be merged before those changes are published in an NPM package.