[Clipclops] Create useKeyboardVerticalOffset hook
#3823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-3823.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-copso9djm4es73efrbog. |
mozzius
changed the title
useKeyboardVerticalOffset hook
mozzius
changed the title
useKeyboardVerticalOffset hookuseKeyboardVerticalOffset hook
|
haileyok
reviewed
May 2, 2024
Comment on lines
+197
to
+201
| return Platform.select({ | ||
| ios: topInset, | ||
| android: screenWindowDifference, | ||
| default: 0, | ||
| }) |
There was a problem hiding this comment.
i remember us having a problem with a Platform.select before in prod but can't remember what exactly it ended up being linked to. Do you remember?
There was a problem hiding this comment.
That was code-spitting related, however these are just numbers so it should be fine
haileyok
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
KeyboardAvoidingViewrequires adjustment to position the input correctly. Previously, I had trial-and-error'd the numbers requires forkeyboardVerticalOffset. However, since the gap looks different on my base iPhone 14 vs the iPhone 15 simulator, I am fairly confident in saying that it's device specific.On iOS: seems like it's the
topsafe area insetOn Android: seems like it's the navigation bar height
To handle this, I moved the logic out to a custom hook