Only run "disable min shell on foregrounding" behaviour if on the home screen #3825
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the "disable min shell on foregrounding" behaviour is in a
useEffect
in the home screen component. However, React Navigation does not unmount components even if you're on a different tab, so this means that this actually happens on every screen in the app, so long as you've loaded the home tab at some point (which you almost certainly have).This wouldn't matter except that the new messages screen uses min shell mode, so if you unbackground it on the messages screen the tab bar overlaps the text input.
I've changed it to use
useFocusEffect
from React Navigation, which only runs the effect when the screen is activeTest plan
Check that the behaviour is unchanged on the home tab
Unbackground on the messages screen, and see that there's no tab bar