Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hide_vertical_scrollbars test #3855

Merged
merged 1 commit into from
May 6, 2024

Conversation

haileyok
Copy link
Contributor

@haileyok haileyok commented May 4, 2024

Why

Since #3429 we've been running some tests where we removed the vertical scroll indicators for some users. In the end - after figuring out the proper way to test this case - it seems that there is not a significant difference in usage between having these scrollbars visible and not having them visible.

I think that there would have been a time that I would have said "since there is not a significant difference in usage, maybe we should just keep the change since it appears cleaner". However, two things have changed my mind on this

  1. I asked some users how they felt about this and - although a really small sample size - they were mostly in favor of keeping the scroll bars visible.
  2. I actually discovered - thanks to this post - that at least on iOS there actually is functionality in the scroll indicator. If you press and hold the indicator, it becomes draggable the same way that you can use it on web.

For both of these reasons, I think we should just leave the scroll bar. Especially whenever it comes to point two, it doesn't seem right to remove something that's actually a feature.

As long as no one else has any objections, lets rm.

Test Plan

Not really much to test here if you have not been testing without indicators, but if you have, you should see the indicators again on the various screens.

Copy link

render bot commented May 4, 2024

@haileyok haileyok requested a review from gaearon May 4, 2024 05:43
Copy link

github-actions bot commented May 4, 2024

Old size New size Diff
6.86 MB 6.86 MB -156 B (-0.00%)

@haileyok
Copy link
Contributor Author

haileyok commented May 4, 2024

Also, to this point Paul left in the PR

Yeah I'm +1 to this, especially with the new profile header behavior it becomes super noticable

I've noticed that there's a ton of mainstream apps where this is the case. Given that it's not really an "us" thing and rather just a "this is the inconsistency that comes with this ecosystem" I think that part just "is what it is" :(

Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alrighty

@gaearon gaearon merged commit b34d224 into main May 6, 2024
6 checks passed
@gaearon gaearon deleted the hailey/remove-vertical-scroll-bar-gate branch May 6, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants