remove hide_vertical_scrollbars
test
#3855
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Since #3429 we've been running some tests where we removed the vertical scroll indicators for some users. In the end - after figuring out the proper way to test this case - it seems that there is not a significant difference in usage between having these scrollbars visible and not having them visible.
I think that there would have been a time that I would have said "since there is not a significant difference in usage, maybe we should just keep the change since it appears cleaner". However, two things have changed my mind on this
For both of these reasons, I think we should just leave the scroll bar. Especially whenever it comes to point two, it doesn't seem right to remove something that's actually a feature.
As long as no one else has any objections, lets rm.
Test Plan
Not really much to test here if you have not been testing without indicators, but if you have, you should see the indicators again on the various screens.