Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A few containWeb List nits #3877

Merged
merged 4 commits into from
May 6, 2024
Merged

A few containWeb List nits #3877

merged 4 commits into from
May 6, 2024

Conversation

haileyok
Copy link
Contributor

@haileyok haileyok commented May 6, 2024 •
edited
Loading

  • Pass the ref to Visibility
  • Use getters for contentHeight et al.

cc @gaearon

Screen.Recording.2024-05-06.at.12.40.49.PM.mov

@render Render
Copy link

render bot commented May 6, 2024

Your Render PR Server URL is https://social-app-pr-3877.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cosiukg21fec73d52kh0.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024 •
edited
Loading

Old size New size Diff
6.87 MB 6.87 MB 269 B (0.00%)

gaearon
gaearon approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg with nit

src/view/com/util/List.web.tsx Outdated Show resolved Hide resolved
@gaearon gaearon merged commit 99f3f10 into main May 6, 2024
6 checks passed
@gaearon gaearon deleted the hailey/list-web-nits branch May 6, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haileyok @gaearon