create new cache key on each run when saving previous commit hash #3898
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, it turns out that
actions/checkout@v4
does not overwrite cache keys. This was revealed after fixing a boolean check last night. Now, TestFlight releases are using a bad previous commit hash which is always triggering a new build now.Instead, let's save to a new key on every run. We'll pull from the cache using the
last-successful-deployment-commit-{branch}-
prefix to find the old one instead of just a static string.Production builds were running appropriately because they do not pull from the cache but rather use version-specific tag for a base commit, so this only affects internal builds.
This also lets us actually use the
cancel-in-progress
correctly, since the cache will actually be properly updated.