Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve localization of {els} string on Create Account page #3912

Merged
merged 27 commits into from
Oct 5, 2024

Conversation

quiple
Copy link
Contributor

@quiple quiple commented May 8, 2024

Makes it easier to localize by providing full context.

스크린샷 2024-09-18 09 51 32
#: src/screens/Signup/StepInfo/Policies.tsx:74
#~ msgid "By creating an account you agree to the {els}."
#~ msgstr ""

#: src/screens/Signup/StepInfo/Policies.tsx:70
msgid "By creating an account you agree to the <0>Privacy Policy</0>."
msgstr ""

#: src/screens/Signup/StepInfo/Policies.tsx:46
msgid "By creating an account you agree to the <0>Terms of Service</0> and <1>Privacy Policy</1>."
msgstr ""

#: src/screens/Signup/StepInfo/Policies.tsx:60
msgid "By creating an account you agree to the <0>Terms of Service</0>."
msgstr ""

Resolves #3660.

Also, change the font color of "Having trouble?" to match the font color of the rest of the page.

@quiple quiple changed the title Localize and in Create Account page Improve localization of {els} string on Create Account page Jun 21, 2024
Copy link
Contributor

@haileyok haileyok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this works on iOS and web. Thank you for doing this, and sorry we let it sit for so long 🙏

@haileyok haileyok merged commit 25e3c93 into bluesky-social:main Oct 5, 2024
6 checks passed
@quiple quiple deleted the localize-and branch October 8, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

{labelTarget}, {els} won't work cross-linguistically
2 participants