Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Flickr album and group pool embeds #3936

Merged
merged 6 commits into from
Jun 4, 2024

Conversation

elfprince13
Copy link
Contributor

Resolve #3576 by adding support for Flickr's embedder - supports both group photo pool and user album links.

Previous additional discussion with @haileyok: https://bsky.app/profile/elfprince13.mumak.app/post/3kqqqqzzvxu2q

@elfprince13 elfprince13 marked this pull request as ready for review May 10, 2024 14:13
@elfprince13
Copy link
Contributor Author

New feature in action

@haileyok
Copy link
Contributor

haileyok commented Jun 4, 2024

Nice, works well from the links that I tested. The little left/right buttons are a bit small on mobile but still pressable nonetheless, and that isn't unique to Flickr. Thanks for adding this in, and sorry review took so long!

@elfprince13
Copy link
Contributor Author

elfprince13 commented Jun 4, 2024 via email

@haileyok haileyok merged commit bd4703c into bluesky-social:main Jun 4, 2024
6 checks passed
@elfprince13 elfprince13 deleted the feature/flickr-embed branch June 4, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Flickr's slideshow embed for album links
2 participants