Use build arg in docker action to correctly pass git commit SHA #3940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-3940.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-coumjpnsc6pc73a3kqh0. |
mozzius
approved these changes
May 10, 2024
haileyok
added a commit
that referenced
this pull request
May 10, 2024
* use env variables through docker args * remove quotes * use an output instead * try that again * write the variables to .env * rm unused * use short sha * remove test branch (cherry picked from commit 1821a99)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
envblock of the action does not end up being available in the Docker container. Instead, we need to usebuild-args.