Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the entire temporary directory instead of just the temp file, also use cacheDirectory over documentDirectory #3985

Merged
merged 2 commits into from
May 13, 2024

Conversation

haileyok
Copy link
Contributor

Matthieu pointed out the temp directory itself might not get deleted, so let's delete the whole thing. Additionally though, let's use cacheDirectory just incase something does happen, since the cache directory will be cleared out by the OS eventually regardless of whether we are successful in deletion ourselves.

Copy link

render bot commented May 13, 2024

Copy link
Contributor

@matthieusieben matthieusieben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haileyok haileyok merged commit 73d094c into main May 13, 2024
6 checks passed
@haileyok haileyok deleted the hailey/delete-temp-directory-too branch May 13, 2024 09:10
Copy link

Old size New size Diff
7.14 MB 7.14 MB 0 B (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants