-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🐴] Pill for additional unreads when coming from background #4043
[🐴] Pill for additional unreads when coming from background #4043
Conversation
Your Render PR Server URL is https://social-app-pr-4043.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cp2pccacn0vc73877en0. |
|
Looks super nice, but I'd expect something to happen when you click on it? Not sure if I'd expect it to scroll to bottom or scroll to the oldest unread message though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I understand more about how this is supposed to be working. This looks good (great in fact) but we should also consider showing this when any new message comes in and you're not scrolled to the bottom
Nice, as long as we're okay with the look then we can definitely do that! |
Also I'm torn on the "should it scroll" too. On one hand it would let you get to the bottom quickly, on the other you'd end up missing the new content 🤔 Still think I lean more toward making it scroll down |
76362f8
into
hailey/foreground-maintain-position
* maintain position after foreground * one possibility * don't overscroll when content size changes. * ignore the rule on 1 item * fix * [🐴] Pill for additional unreads when coming from background (#4043) * create a pill with some animatons * add some basic styles to the pill * make the animations reusable * bit better styling * rm logs --------- Co-authored-by: Samuel Newman <mozzius@protonmail.com> * import --------- Co-authored-by: Samuel Newman <mozzius@protonmail.com>
Stacked on #4027
Needs some styling work, but not sure how to make it look right now.
Go to about 2/3 of the way through the video to see effect when foregrounding.
Screen.Recording.2024-05-15.at.11.25.09.PM.mov