check maxTouchPoints is greater than 1 - not 0 - for hover card
#4158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4158.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cp6f0vnsc6pc73avemg0. |
|
mozzius
approved these changes
May 21, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Right now the hover cards do not work on Firefox Windows are not working, because - specifically on Windows and specifically with Firefox -
maxTouchPointsis set to one, not zero.The MDN docs also say that we should be using
> 1instead of> 0https://developer.mozilla.org/en-US/docs/Web/API/Navigator/maxTouchPoints
Test Plan
Now that we are using
> 1, this works correctly.Before and after, on bsky.app vs localhost.
Screen.Recording.2024-05-21.at.12.05.00.PM.mov