-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't use contentVisibility
on Firefox
#4164
Conversation
Your Render PR Server URL is https://social-app-pr-4164.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cp6p7cv79t8c73ast0d0. |
@gaearon I mentioned in Slack that I'm not certain what we're using this style for. It isn't (visibly anyway?) causing problems elsewhere in the app that we know of, so if it is useful for some reason we can scope this down further, maybe with a prop on |
|
It's guaranteed to ruin layout/scroll animations, because unless the browser knows it should render it, then the elements are assumed to have no height/width initially, which is what I presume is happening. It can be remedied with |
Ah that does make sense. Kind of wonder if this is what causes the ghost scroll position issues for some people (the content flashing up and down the screen). We still get reports of that occasionally though have never been able to reproduce. |
Hmm, it might be, and not sure if it's something that can be remedied easily too. There is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm
Why
The
content-visibility
style on Firefox is causing problems with theList
implementation - at least for the list we use for chat conversations.This PR just checks the useragent for
Firefox
and does not use this style - the same way we do not use it for Safari - if it matches.Test Plan
With this PR, the chat list should be fine on Firefox.
Screen.Recording.2024-05-21.at.11.40.56.PM.mov