add profiles to search history #4169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
reviewed
May 30, 2024
gaearon
reviewed
May 30, 2024
gaearon
force-pushed
the
feature/search-history-profiles
branch
from
dadbde2 to
5568fb1
Compare
|
A few issues. Currently, pressing the avatar hides the dropdown before pushing the next view. That causes flicker: bug1.movI think we'd want to avoid that. Another problem is that pushing an autocomplete result now seems to navigate twice. bug2.movIt seems like you're adding some navigation logic — maybe existing logic could be reused? Whatever we're doing for the existing autocomplete. I presume it wouldn't have those issues? But I haven't looked closely. |
gaearon
requested changes
May 31, 2024
|
it looks like removing this fixes the issues: scrollToTopWeb()
setShowAutocomplete(false)
updateSelectedProfiles(profile)additionally, i changed the navigateToProfile function to be asynchronous. |
|
seems like Back button is broken stuck.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR satisfies #2513, a duplicate of #1677. The SearchHistory component is enhanced by fully implementing the display of recent profiles. Each recent profile now includes the avatar, display name, and handle. Additionally, the display name and handle are truncated with ellipses if they exceed a specified character limit to ensure they fit within the given space.