HomeMenuItem goes above SearchMenuItem in a sessioned Drawer #4180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haileyok
approved these changes
May 23, 2024
|
Yeah other apps often have search at the top? |
|
Oh really? I guess that makes sense...Of course people are only now noticing this because they have to open this panel to get to feeds. I don't feel strongly one way or the other, though imo it feels a little off. |
haileyok
requested changes
May 23, 2024
|
Sits in the waiting room, flips through Poster's Monthly magazine |
|
It works now for some reason(?). I am closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsure if this is wanted but in a Drawer with a session, move Home to the top to be consistent with other navigation menus.
Before
After