Handle zero bottom inset on iOS #4184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4184.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cp7abhq0si5c73fmodg0. |
haileyok
force-pushed
the
hailey/handle-zero-inset
branch
from
feb51bc to
9ffb12a
Compare
haileyok
force-pushed
the
hailey/handle-zero-inset
branch
from
9ffb12a to
39935c6
Compare
|
haileyok
commented
May 23, 2024
| @@ -221,8 +222,7 @@ export function MessagesList({ | |||
|
|
|||
| // -- Keyboard animation handling | |||
| const {bottom: bottomInset} = useSafeAreaInsets() | |||
| const nativeBottomBarHeight = isIOS ? 42 : 60 | |||
| const bottomOffset = isWeb ? 0 : bottomInset + nativeBottomBarHeight | |||
| const bottomOffset = isWeb ? 0 : clamp(60 + bottomInset, 60, 75) | |||
There was a problem hiding this comment.
This 15 pixel range comes from
gaearon
approved these changes
May 23, 2024
haileyok
added a commit
that referenced
this pull request
May 23, 2024
* set message padding to a minimum of 60 and max of 70 * adjust range (cherry picked from commit 69f4684)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
It is fairly difficult on iOS for us to calculate our real safe area because our bottom is clamping the padding based on the device's inset. For example, on an iPhone 8 or lower, the padding gets set to
15- because the real bottom inset is0. However, on other devices it becomes30because the inset is set (an iPhone X or higher has a bottom inset of34).this results in some bad behavior with the message input in the chat screen. We need to account for this missing padding in these circumstances.
On most devices this offset is very small, even on Android devices. Newer iPhone devices have the tallest offsets, so for thos devices we want to set the max to 76. The minimum - when the offset is zero - should be 60.
Test Plan
With the adjusted offset for these circumstances, all devices should appear to have the same style for the text input