Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐴] add link to chat settings from main settings #4197

Merged
merged 2 commits into from
May 23, 2024

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented May 23, 2024

Fixes #4195

Added under basic

image

Copy link

render bot commented May 23, 2024

Copy link

Old size New size Diff
7.29 MB 7.29 MB 2.46 KB (0.03%)

/>
</View>
<Text type="lg" style={pal.text}>
<Trans>Chat Settings</Trans>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Trans>Chat Settings</Trans>
<Trans>Chat Preferences</Trans>

We use "Preferences" everywhere else here, but fwiw we are using "Settings" on the actual settings screen itself...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't feel strongly, we can change this whenever.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Settings here, just so it's the same when you click through. Don't feel strongly either tho

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I realized that after going into the screen. Another option might be to just drop the "Settings" all together. You're in "Settings" already so you know it takes you to more settings.

Again though, that doesn't follow the other behavior we have lol...probably just something to revisit when we rework this screen hopefully soon.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't wait to burn it all down fr

weird ass diff on this commit lol
@mozzius mozzius merged commit 0e77280 into main May 23, 2024
6 checks passed
@mozzius mozzius deleted the samuel/settings-to-chat-settings branch May 23, 2024 17:57
haileyok pushed a commit that referenced this pull request May 23, 2024
* add link to chat settings from main settings

* move to beneath saved feeds

weird ass diff on this commit lol

(cherry picked from commit 0e77280)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add a link to Messages settings in the Moderation settings
2 participants