-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🐴] add link to chat settings from main settings #4197
Conversation
Your Render PR Server URL is https://social-app-pr-4197.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cp7ne320si5c73fnho70. |
|
src/view/screens/Settings/index.tsx
Outdated
/> | ||
</View> | ||
<Text type="lg" style={pal.text}> | ||
<Trans>Chat Settings</Trans> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<Trans>Chat Settings</Trans> | |
<Trans>Chat Preferences</Trans> |
We use "Preferences" everywhere else here, but fwiw we are using "Settings" on the actual settings screen itself...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't feel strongly, we can change this whenever.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Settings here, just so it's the same when you click through. Don't feel strongly either tho
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea I realized that after going into the screen. Another option might be to just drop the "Settings" all together. You're in "Settings" already so you know it takes you to more settings.
Again though, that doesn't follow the other behavior we have lol...probably just something to revisit when we rework this screen hopefully soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't wait to burn it all down fr
weird ass diff on this commit lol
* add link to chat settings from main settings * move to beneath saved feeds weird ass diff on this commit lol (cherry picked from commit 0e77280)
Fixes #4195
Added under basic