Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update French localizations #4223

Merged
merged 6 commits into from
Jun 5, 2024

Conversation

Signez
Copy link
Contributor

@Signez Signez commented May 26, 2024

A few more strings that were introduced / changed just after my last pass on translations (it happens! 🤷‍♂️), mainly about the Chat feature.

Pinging @surfdude29 and @pfrazee as usual, but nothing should raise any eyebrows anyway :)

@Signez Signez force-pushed the fr-l10n-may-24-the-return branch from 70d9cfc to 8b5547b Compare May 26, 2024 19:38
Copy link
Contributor

@surfdude29 surfdude29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, excellent work as always @Signez 👌

I just have two points I wanted to mention.

src/locale/locales/fr/messages.po Outdated Show resolved Hide resolved
src/locale/locales/fr/messages.po Outdated Show resolved Hide resolved
@surfdude29
Copy link
Contributor

Also, I have one change to suggest that's not in this PR; I think the second string below can be simplified to match the first string:

#: src/view/screens/Settings/index.tsx:566
msgid "Following feed preferences"
msgstr "Préférences du fil d’actu « Following »"
#: src/Navigation.tsx:269
#: src/view/com/home/HomeHeaderLayout.web.tsx:64
#: src/view/com/home/HomeHeaderLayoutMobile.tsx:87
#: src/view/screens/PreferencesFollowingFeed.tsx:103
#: src/view/screens/Settings/index.tsx:575
msgid "Following Feed Preferences"
msgstr "Préférences en matière de fil d’actu « Following »"

@surfdude29
Copy link
Contributor

And the suggested change from a user in #4296 is here:

#: src/view/com/composer/Composer.tsx:579
msgid "Discard"
msgstr "Ignorer"

@Signez Signez force-pushed the fr-l10n-may-24-the-return branch from 8b5547b to c4237d2 Compare May 31, 2024 13:46
@Signez
Copy link
Contributor Author

Signez commented May 31, 2024

@surfdude29 Thanks again for your review!

All the suggested changes were applied in this commit, including the fix for #4296 and that weird long string for Following Feed Settings (that bothered me too, but I forgot to fix it somehow before); I also took the time to bump the locales again and translate three new, very basic strings to keep this PR up-to-date.

@pfrazee Now that this was reviewed by a peer, I think you can merge this with confidence :)

@Signez Signez force-pushed the fr-l10n-may-24-the-return branch from c4237d2 to d4e87ad Compare June 2, 2024 22:18
Copy link
Collaborator

@pfrazee pfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@pfrazee pfrazee merged commit 47033e5 into bluesky-social:main Jun 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants