-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update French localizations #4223
Conversation
70d9cfc
to
8b5547b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, excellent work as always @Signez 👌
I just have two points I wanted to mention.
Also, I have one change to suggest that's not in this PR; I think the second string below can be simplified to match the first string: social-app/src/locale/locales/fr/messages.po Lines 2035 to 2045 in 8b5547b
|
And the suggested change from a user in #4296 is here: social-app/src/locale/locales/fr/messages.po Lines 1391 to 1393 in 8b5547b
|
8b5547b
to
c4237d2
Compare
@surfdude29 Thanks again for your review! All the suggested changes were applied in this commit, including the fix for #4296 and that weird long string for Following Feed Settings (that bothered me too, but I forgot to fix it somehow before); I also took the time to bump the locales again and translate three new, very basic strings to keep this PR up-to-date. @pfrazee Now that this was reviewed by a peer, I think you can merge this with confidence :) |
Thanks @surfdude29 for the review! Fixes bluesky-social#4296.
c4237d2
to
d4e87ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
A few more strings that were introduced / changed just after my last pass on translations (it happens! 🤷♂️), mainly about the Chat feature.
Pinging @surfdude29 and @pfrazee as usual, but nothing should raise any eyebrows anyway :)