Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alt text followups -- SLIGHTLY larger, and update gifs #4252

Merged
merged 2 commits into from
May 29, 2024
Merged

Alt text followups -- SLIGHTLY larger, and update gifs #4252

merged 2 commits into from
May 29, 2024

Conversation

pfrazee
Copy link
Collaborator

@pfrazee pfrazee commented May 29, 2024

  • Slightly bumped up the text size of the alt text indicator
  • Moved the GIF alt indicator to the right
    • On Web, kept the GIF alt indicator large because it needs to be specifically clicked
    • On Mobile, made it small but gave a larger hit slop

Images

Before After
CleanShot 2024-05-28 at 20 23 12@2x CleanShot 2024-05-28 at 20 22 23@2x

Gifs

Before After (Web) After (Mobile)
CleanShot 2024-05-28 at 19 57 50@2x CleanShot 2024-05-28 at 19 59 55@2x CleanShot 2024-05-28 at 20 05 08@2x

@render Render
Copy link

render bot commented May 29, 2024

Your Render PR Server URL is https://social-app-pr-4252.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cpb9vh674orc7397v5ng.

@github-actions GitHub Actions
Copy link

Old size New size Diff
7.23 MB 7.23 MB 16 B (0.00%)

@gaearon gaearon merged commit efdfb7f into main May 29, 2024
6 checks passed
@gaearon gaearon deleted the paul/alt-text-followups branch May 29, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haileyok haileyok haileyok approved these changes

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pfrazee @gaearon @haileyok