use xcode 15.3 #4253
Merged
use xcode 15.3 #4253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4253.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cpbbgbocmk4c73b8nhb0. |
|
haileyok
commented
May 29, 2024
| @@ -80,11 +84,11 @@ jobs: | |||
| - name: ⬇️ Restore Cache | |||
| id: get-base-commit | |||
| uses: actions/cache@v4 | |||
| if: ${{ inputs.profile == 'testflight' && github.ref == 'refs/heads/main' }} | |||
| if: ${{ inputs.profile == 'testflight' }} | |||
There was a problem hiding this comment.
Tweaked this bad copy/paste from before. Not necessary to limit this by ref since we can build off any branch, not just main.
mozzius
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We added some code recently to a native module that requires iOS 17.4.1. To build for that iOS version, we need XCode 15.3 or greater.
See https://github.com/actions/runner-images/blob/main/images/macos/macos-14-Readme.md#installed-sdks. We are already using
macos-14, so15.3should be available and will give us access to the 17.4 SDK.Test Plan
Merge, see if the action runs.